Change for 7702 for devnet-4 #7590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ak88
assigned MarekM25 and smartprogrammer93 and unassigned MarekM25 and smartprogrammer93
LukaszRozmej
approved these changes
Oct 11, 2024
MarekM25
approved these changes
Oct 25, 2024
| private bool ValidateAuthoritySignature(Signature signature) | ||
| { | ||
| UInt256 sValue = new(signature.SAsSpan, isBigEndian: true); | ||
|
|
There was a problem hiding this comment.
Why is this not needed anymore?
There was a problem hiding this comment.
It went from invalidating the tx to just invalidating the tuple instead, so the check is now in TransactionProcessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New spec for 7702 here:
https://eips.ethereum.org/EIPS/eip-7702
Changes
assert auth.chain_id < 2 **64
assert auth.nonce < 2 **64
assert len(auth.address) == 20
assert auth.y_parity < 2 **8
assert auth.r < 2 **256
assert auth.s < 2 **256
Tuple fields have been bounded by their type during RLP serialization/deserialization, so any field exceeding the bounds will result in
RlpExceptionWhat types of changes does your code introduce?